Merge pull request #2918 from HalfWhitt/app-condtional

Set App.app to initial value of None to avoid AttributeError in teardown
beeware · Oct 17, 2024 · 261e356 · 261e356
2 parents 9261f89 + 671b9c3
commit 261e356
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/changes/2918.bugfix.rst b/changes/2918.bugfix.rst
@@ -0,0 +1 @@
+App.app is now set to an initial value of None, before an app instance is created. This avoids a potential Attribute Error in testing teardown.
diff --git a/core/src/toga/app.py b/core/src/toga/app.py
@@ -134,8 +134,9 @@ def _remove(self, id: str) -> None:
 
 class App:
     #: The currently running :class:`~toga.App`. Since there can only be one running
-    #: Toga app in a process, this is available as a class property via ``toga.App.app``.
-    app: App
+    #: Toga app in a process, this is available as a class property via
+    #: ``toga.App.app``. If no app has been created yet, this is set to ``None``.
+    app: App | None = None
     _impl: Any
     _camera: Camera
     _location: Location