This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
Fix compatibility with Python 3.13 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_UnixSelectorEventLoop in Python 3.13 expect _unix_server_sockets dict, add one. It's later used (among others) in _stop_serving(), but not in close() directly, so just adding attribute is enough. The related CPython change: 74b868f636a "gh-111246: Remove listening Unix socket on close (#111483)" Add a test for unix sockets too.
freakboy3742
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Thanks for the patch. I've made a couple of minor corrections, but otherwise this looks good.
Just so you're aware: we will likely be archiving this project in the near future. PyGObject recently merged a patch that added native asyncio support, which removes the need for Gbulb as an external project. See #32 for details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_UnixSelectorEventLoop in Python 3.13 expect _unix_server_sockets dict, add one. It's later used (among others) in _stop_serving(), but not in close() directly, so just adding attribute is enough.
The related CPython change: 74b868f636a "gh-111246: Remove listening Unix socket on close (#111483)"
PR Checklist: