Skip to content

Bugfix-2071: Fixed bug where a double quote in the Formal Name would cause invalid strings. #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dev-adas wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix-2071: Fixed bug where a double quote in the Formal Name would cause invalid strings. #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26a183
Bugfix 2071: Remove prev commit, handle quotes when logging on macOS
dev-adas May 19, 2025
573c520
Update changes/2071.bugfix.rst
dev-adas May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/2071.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Apps whose formal name includes a `"` are now correctly handled on macOS.
4 changes: 3 additions & 1 deletion src/briefcase/platforms/macOS/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,9 @@ def run_gui_app(
# as the process will generate lots of system-level messages.
# We can't filter on *just* the senderImagePath, because other
# apps will generate log messages that would be caught by the filter.
sender = os.fsdecode(self.binary_path(app) / "Contents/MacOS" / app.formal_name)
sender = os.fsdecode(
self.binary_path(app) / "Contents/MacOS" / app.formal_name
).replace('"', '\\"')
log_popen = self.tools.subprocess.Popen(
[
"log",
Expand Down