fix: finding stub app on macOS with . in formal name#2213
Open
Mr-Sunglasses wants to merge 1 commit intobeeware:mainfrom
Open
fix: finding stub app on macOS with . in formal name#2213Mr-Sunglasses wants to merge 1 commit intobeeware:mainfrom
. in formal name#2213Mr-Sunglasses wants to merge 1 commit intobeeware:mainfrom
Conversation
freakboy3742
requested changes
Mar 27, 2025
Member
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for the PR!
You've got the general form of the solution correct - but there's a couple of housekeeping issues you need to take care of to get CI to pass. The most immediate problem is the lack of a changenote - you need to add a file that describes the change as it will appear in the release notes. Once you've fixed that, I suspect you'll hit two other problems:
- a code style issue picked up by
black; and - a test coverage failure. We have 100% branch coverage in our test suite; you're adding a fix for a bug here, so it should be accompanied by a test for that bug.
The Briefcase contribution guide describes the things you need to do as part of a PR, and how to set up your local environment to perform those checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #2151
.in formal namePR Checklist: