Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PyScript 2024.11.1 #2080

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Dec 9, 2024

Removed all obsolete PyScript settings. Since these settings were required by the old template, also added a platform_target_version.

The corresponding template PR should be merged first:

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some additional changes, allowing the initial pyscript.toml to come from the template. This allows us to adapt to any future "base configuration" changes in the template, rather than in code.

Marking as accepted since I'm happy with the changes; leaving to @mhsmith for a final cross-check and merge.

@mhsmith mhsmith merged commit 91e6caa into beeware:main Dec 10, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants