Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue1746- fixed the toml escape #1811

Merged
merged 5 commits into from
May 20, 2024
Merged

issue1746- fixed the toml escape #1811

merged 5 commits into from
May 20, 2024

Conversation

mas192
Copy link
Contributor

@mas192 mas192 commented May 20, 2024

TOMLEscape class was fixed to properly escape doublequotes and backslash and the test files were corrected accordingly.
Now author creation can include single and double quotes at the time of creation
PR relates to an issue, Fixes #1746

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comment cleanups, but otherwise this looks great! Thanks!

changes/1746.bugfix.rst Outdated Show resolved Hide resolved
src/briefcase/integrations/cookiecutter.py Outdated Show resolved Hide resolved
@freakboy3742 freakboy3742 merged commit 3da7458 into beeware:main May 20, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new project using quoted inputs results in an invalid pyproject.toml
2 participants