Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM and PKG packages need license information #1829

Open
MarieRoald opened this issue May 21, 2024 · 1 comment
Open

RPM and PKG packages need license information #1829

MarieRoald opened this issue May 21, 2024 · 1 comment
Labels
bug A crash or error in behavior.

Comments

@MarieRoald
Copy link
Contributor

MarieRoald commented May 21, 2024

Describe the bug

RPM and PKG packages include a short descriptor for the license, but after #1812 Briefcase will no longer know that (it either has a licence file or a licence text which may or may not be a short descriptor). Consequently, it is always set to "Unknown".

Prior to #1812 briefcase might have a way to know the license descriptor, but it is no guarantee that it matches the LICENSE file.

Steps to reproduce

  1. Build an RPM or PKG bundle
  2. Look at the spec file
  3. Observe that the "License" field is set to "Unknown"

Expected behavior

A short license descriptor is included in the RPM spec file and the PKGBUILD-file

Screenshots

No response

Environment

Any environment

Logs

No response

Additional context

No response

@MarieRoald MarieRoald added the bug A crash or error in behavior. label May 21, 2024
@MarieRoald MarieRoald changed the title RPM packages need license information RPM and PKG packages need license information May 21, 2024
@freakboy3742
Copy link
Member

As a suggested fix: when the license configuration item is parsed, it should be parsed into a License object that has properties for the different forms that the license can take - the path on disk, the literal text of the license, a short descriptor of the license (in SPDX format, plus PyPA-compatible format). It should be possible to construct the License instance from any of the legal input types that PEP621 allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A crash or error in behavior.
Projects
None yet
Development

No branches or pull requests

2 participants