Open
Conversation
…ting what is exported in the __init__.py file.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 93.26% 91.94% -1.33%
==========================================
Files 16 18 +2
Lines 817 1067 +250
Branches 118 156 +38
==========================================
+ Hits 762 981 +219
- Misses 35 56 +21
- Partials 20 30 +10
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a deprecation system to clean up the public API and prepares for the v1.0.0 release.
Note: While not entirely necessary, I moved the
MediaFileclass into its own file. This cleans the__init__.pyfile to be responsible for import/export only. This simplified the deprecation process significantly and makes very clear what is exposed by mediafile going forward.Changes:
__init__.pyto expose only core API (MediaFile,Image, exceptions) in its__all__MediaFileclass to dedicated file for better organizationMigration:
Existing imports still work but raise a warnings: