Conversation
for the mutagen file type.
Moved null value into constants
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 93.26% 93.34% +0.08%
==========================================
Files 16 17 +1
Lines 817 842 +25
Branches 118 115 -3
==========================================
+ Hits 762 786 +24
+ Misses 35 34 -1
- Partials 20 22 +2
|
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more comprehensive typing to the
mediafile/fields.pymodule using generics. Fields are now typed asMediaField[T]whereTcorresponds to theout_typeof the field. This allows type checkers and IDEs to more accurately infer field types.Example:
Most fields are still
MediaField[unknown], but this PR is a partial step toward fully typed fields. Additional PRs will follow to further improve typing across mediafile.Now might be a good time to have a look at this to not increase the review burden too much.