Fix CI run of #5152 #5186
Closed
Fix CI run of #5152 #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the changelog really necessary for this pr? |
|
It's not necessary. The failure is just a reminder that it hasn't been done, and we're still discussing whether it should be changed to a message. Don't worry about it. |
|
Given that this is contained in #5152, I'm going to close this one. Doing both is unnecessary and will create a merge conflict if we do both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
minor fix
Fixes CI run of #5152
did not want to make it a part of that PR since it is unrelated and blame gets assigned correctly.
To Do