added testcase for fields command #1614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first check of function without check of consistent output
test/test_ui_commands.py
Outdated
Member
There was a problem hiding this comment.
If you inherit from _common.LibTestCase instead of plain _common.TestCase, you'll get self.lib for free.
Member
|
Looking good! Yes, checking against a fixed list would work. To make the test slightly more robust to changes, though, it may be a good idea to read out It might also be nice to check the display of plugin-provided fields, which would involve cooking up a dummy plugin for the test. |
Contributor
Author
|
ok, i just added a method to test the output (not very strong, but robust against changes in output) |
Member
|
Looks ideal! Thank you again! ✨ |
sampsyo
added a commit
that referenced
this pull request
Sep 25, 2015
added testcase for fields command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my second test. I want to check the command "fields" of beets. I think the coverage of this would be ok now, but at the moment i don't check the output of the program. So i don't really want you to merge this branch at the moment.
Do you have any suggestions, how we should test it? I think it would not make sense to test it against a fixed list of text.