fix: make FanCurveControl DPI-aware

[beenycool]

Summary

• Convert hardcoded constants (PointRadius, Margins) to scale with DeviceDpi
• Ensures proper rendering on high-DPI displays

Summary by CodeRabbit

• Bug Fixes
  • Improved fan curve control interface scaling on high-DPI and scaled displays for better visibility and interaction accuracy.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Replaced five fixed pixel constants in FanCurveControl.cs with dynamic properties that scale values using LogicalToDeviceUnits(). All rendering calculations and hit-testing now adapt to device units instead of relying on compile-time pixel values.

Changes

Cohort / File(s)	Summary
DPI-Aware Scaling AsusFanControlGUI/FanCurveControl.cs	Converted PointRadius, MarginLeft, MarginBottom, MarginRight, and MarginTop from static pixel constants to dynamic properties that scale values based on device units for improved high-DPI display support.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• fix: UI timer disposal, PerformanceCounter blocking, and diagnostics #23: Modifies the same FanCurveControl.cs file with changes to curve population and mouse-delete logic, addressing different aspects of the same control component.

Poem

🐰 With whiskers twitched, this rabbit sees,
Constants dancing, pixels freed—
From fixed to flow, the curves now scale,
High-DPI screens? We shall not fail! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: converting hardcoded UI constants to be DPI-aware using LogicalToDeviceUnits scaling.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch pr5-dpi-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)

• AsusFanControlGUI/FanCurveControl.cs

---

_{Reviewed by trinity-large-thinking · 139,950 tokens}

[gemini-code-assist]

Code Review

This pull request introduces DPI scaling for the fan curve control's margins and point radius by replacing static constants with dynamic properties. The review feedback suggests using the built-in LogicalToDeviceUnits method for more efficient and accurate scaling, and recommends extending this scaling to other hardcoded pixel values throughout the file.

[gemini-code-assist]

The current implementation recalculates the scaled values every time these properties are accessed. Since they are used frequently within OnPaint (including inside loops) and event handlers, this introduces redundant floating-point calculations. Additionally, casting to int truncates the result, which can lead to slight rendering inaccuracies compared to rounding.

A more efficient and idiomatic approach in Windows Forms (available since .NET Framework 4.7) is to use the built-in LogicalToDeviceUnits method. This method handles the scaling logic and rounding correctly.

Also, note that to achieve full DPI awareness, you should consider applying similar scaling to other hardcoded pixel values in the file, such as pen widths (e.g., line 101) and text offsets (e.g., lines 88, 93, 131).

        private int PointRadius => LogicalToDeviceUnits(6);
        private int MarginLeft => LogicalToDeviceUnits(40);
        private int MarginBottom => LogicalToDeviceUnits(30);
        private int MarginRight => LogicalToDeviceUnits(20);
        private int MarginTop => LogicalToDeviceUnits(20);