[refactor] Removed the getHandleByIndex from the PowerMetric interfac… #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. This method was used to load the device pointer from a device index that was obtained via the device context. This functionality is now performed during the initialization function.
jjfumero
added a commit
to jjfumero/TornadoVM
that referenced
this pull request
Sep 30, 2024
Improvements ============ - beehive-lab#565: New API call in the Execution Plan to log/trace the executed configuration plans. - beehive-lab#563: Expand the TornadoVM profiler with Level Zero Sysman Energy Metrics. - beehive-lab#559: Refactoring Power Metric handlers for PTX and OpenCL. - beehive-lab#548: Benchmarking improvements. - beehive-lab#549: Prebuilt API tests added using multiple backend-setup. - Add internal tests for monitoring memory management [link](beehive-lab@0644225). Compatibility ============= - beehive-lab#561: Build for OSx 14.6 and OSx 15 fixed. Bug Fixes ============== - beehive-lab#564: Jenkins configuration fixed to run KFusion per backend. - beehive-lab#562: Warmup action from the Execution Plan fixed to run with correct internal IDs. - beehive-lab#557: Shared Execution Plans Context fixed. - beehive-lab#553: OpenCL compiler flags for Intel Integrated GPUs fixed. - beehive-lab#552: Fixed runtime to select any device among multiple SPIR-V devices. - Fixed zero extend arithmetic operations: [link](beehive-lab@ea7b602).
jjfumero
added a commit
to jjfumero/TornadoVM
that referenced
this pull request
Sep 30, 2024
Improvements ============ - beehive-lab#565: New API call in the Execution Plan to log/trace the executed configuration plans. - beehive-lab#563: Expand the TornadoVM profiler with Level Zero Sysman Energy Metrics. - beehive-lab#559: Refactoring Power Metric handlers for PTX and OpenCL. - beehive-lab#548: Benchmarking improvements. - beehive-lab#549: Prebuilt API tests added using multiple backend-setup. - Add internal tests for monitoring memory management [link](beehive-lab@0644225). Compatibility ============= - beehive-lab#561: Build for OSx 14.6 and OSx 15 fixed. Bug Fixes ============== - beehive-lab#564: Jenkins configuration fixed to run KFusion per backend. - beehive-lab#562: Warmup action from the Execution Plan fixed to run with correct internal IDs. - beehive-lab#557: Shared Execution Plans Context fixed. - beehive-lab#553: OpenCL compiler flags for Intel Integrated GPUs fixed. - beehive-lab#552: Fixed runtime to select any device among multiple SPIR-V devices. - Fixed zero extend arithmetic operations: [link](beehive-lab@ea7b602).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the interface of PowerMetric.java. This interface exposed three methods:
initializePowerLibrary(): responsible for initializing data structures to be used for querying underlying power metrics from the heterogeneous libraries (e.g., CUDA NVML).getHandleByIndex(long[] device): this method was using a device index from the device context in order to load the device pointers into an array.getPowerUsage(long[] powerUsage): this method loads the power metrics in an input array.The second method performs inner low-level functionality, and is not necessary to be exposed in the device context. This is because the
PowerMetricconstructor in theOpenCLandPTXimplementations accepts as input the device context. So, this method can be removed from the interface and be performed during the initialization (as part of the first method).Relevance to previous PRs: #377
Problem description
This refactoring will enable the smooth integration of the power functions for the
LevelZeroimplementation and theSPIR-Vbackend.Backend/s tested
Mark the backends affected by this PR.
OS tested
Mark the OS where this PR is tested.
Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.
How to test the new patch?
To test, you can run: