Issue #506 has been fixed. #513

andrii0lomakin · 2024-07-27T13:38:39Z

Issue #506 has been fixed.
Not used nodes, not related to any API or code, has been removed.
GraalVM JIT has been added as provided dependency to improve IDE support.

Mark the backends affected by this PR.

OpenCL
PTX
SPIRV

OS tested

Mark the OS where this PR is tested.

Linux
OSx
Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

Yes
No

How to test the new patch?

Provide instructions about how to test the new patch.

tornado-test -V uk.ac.manchester.tornado.unittests.TestHello

Not used nodes, not related to any API or code, has been removed. GraalVM JIT has been added as provided dependency to improve IDE support.

…f correct values.

jjfumero · 2024-07-29T07:52:13Z

Thanks for the contribution. It looks much cleaner.
This PR applies for OpenCL backend. I will remove the PTX mark from this PR.

Before we merge, @mikepapadim , can you merge this into a new branch that includes JDK22? I want to see how these plugins will work as they are.

It works on Linux. I will check on OSx.

jjfumero · 2024-07-29T08:06:47Z

...a/uk/ac/manchester/tornado/drivers/opencl/graal/compiler/plugins/OCLGraphBuilderPlugins.java

@@ -430,39 +366,6 @@ public boolean apply(GraphBuilderContext b, ResolvedJavaMethod targetMethod, Rec
    }

    private static void registerTornadoVMIntrinsicsPlugins(InvocationPlugins plugins) {
-        final InvocationPlugin tprintfPlugin2 = new InvocationPlugin("tprintf", String.class, Object[].class) {


I see the tprinf intrinsic is removed, which makes sense. We can debug directly using the Debug.printf method.

jjfumero

LGTM

jjfumero · 2024-07-29T08:21:59Z

For completeness: printf function does not work (does not print anything) on Apple M1-M3 OpenCL implementations, despite that it is OpenCL 1.2. This is a driver issue, and nothing related to this PR.

andrii0lomakin · 2024-07-29T08:35:41Z

@jjfumero For completeness, I also observed issues with PTX and vprintf, but because I have not made a deep investigation, I will provide a separate PR + Issue once we start to work with it closely. Right now, we are concentrating on OpenCL kernels. Because the OpenCL backend is the most widely provided, and then we will work on performance optimizations for specific backends.

mikepapadim

LGTM, thanks

I also tested with the new port JDK22 and it works.

stratika · 2024-07-29T11:03:04Z

tornado-unittests/src/main/java/uk/ac/manchester/tornado/unittests/TestHello.java

+    public void testPrintIntArray() throws TornadoExecutionPlanException {
+        assertNotBackend(TornadoVMBackendType.SPIRV);


Please add also the assertNotBackend check for the PTX type.

Yes, good catch

stratika

thanks @andrii0lomakin, it looks really cool to have this feature supported. The code looks good to me. Just one comment regarding the test. I would suggest to extend it to assess also that the printing works with the parallel loop (I already tested it in my laptop and it works).

I will test it in a bit in Windows for sanity check and will let you know.

stratika · 2024-07-29T12:23:33Z

tornado-unittests/src/main/java/uk/ac/manchester/tornado/unittests/TestHello.java

+    private static void printIntArray(IntArray a) {
+        int firstValue = a.get(0);
+        int secondValue = a.get(1);
+
+        if (a.getSize() > 1) {
+            Debug.printf("First value %d, second value %d\n", firstValue, secondValue);
+        }
+    }
+


I would suggest to complement this test, or add a second one that prints the value of each element in the input array, and uses the @parallel annotation, so that to test the indices passed from the GlobalThreadIdNode.

e.g.,

private static void printIntArray(IntArray a) { for (@Parallel int i = 0; i < a.getSize(); i++) { Debug.printf("value a[%d] = %d\n", i, a.get(i)); } }

Ideally, we can extend the test to assess all 3 dimensions.

stratika · 2024-07-29T12:48:26Z

It works on my laptop with Windows 11.

andrii0lomakin · 2024-07-30T05:34:38Z

Hi @stratika
Thank you for your help.
I have added new tests.

jjfumero

LGTM

stratika

LGTM, thanks

jjfumero · 2024-07-30T08:25:45Z

Thanks all, I will merge this PR

Improvements ~~~~~~~~~~~~~~~~~~ - beehive-lab#468: Cleanup Abstract Metadata Class. - beehive-lab#473: Add maven plugin to build TornadoVM source for the releases. - beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`. - beehive-lab#482: Help messages improve when an out-of-memory exception is raised. - beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class. - beehive-lab#487: Prebuilt API simplified. - beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments. - beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development. - beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay. - beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks. - beehive-lab#538: `README` file updated. - beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero). - beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer. Compatibility ~~~~~~~~~~~~~~~~~~ - beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2. - beehive-lab#486: Temurin for Windows added in the list of supported JDKs. - beehive-lab#525: Revert usage of String Templates in preparation for JDK 23. - beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay). - beehive-lab#513: LevelZero JNI Library updated to v0.1.4. Bug Fixes ~~~~~~~~~~~~~~~~~~ - beehive-lab#470: README documentation fixed. - beehive-lab#478: Fix the test names that are present in the white list. - beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed. - beehive-lab#493: Tests Whitelist for PTX backend fixed. - beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions. - beehive-lab#514: Installer script fixed. - beehive-lab#540: Fix issue with clean-up execution IDs function. - beehive-lab#541: Fix Data Accessors for the prebuilt API. - beehive-lab#543: Fix checkstyle condition and FP16 error message improved.

Improvements ~~~~~~~~~~~~~~~~~~ - beehive-lab#468: Cleanup Abstract Metadata Class. - beehive-lab#473: Add maven plugin to build TornadoVM source for the releases. - beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`. - beehive-lab#482: Help messages improved when an out-of-memory exception is raised. - beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class. - beehive-lab#487: Prebuilt API simplified. - beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments. - beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development. - beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay. - beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks. - beehive-lab#538: `README` file updated. - beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero). - beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer. Compatibility ~~~~~~~~~~~~~~~~~~ - beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2. - beehive-lab#486: Temurin for Windows added in the list of supported JDKs. - beehive-lab#525: Revert usage of String Templates in preparation for JDK 23. - beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay). - beehive-lab#513: LevelZero JNI Library updated to v0.1.4. Bug Fixes ~~~~~~~~~~~~~~~~~~ - beehive-lab#470: README documentation fixed. - beehive-lab#478: Fix the test names that are present in the white list. - beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed. - beehive-lab#493: Tests Whitelist for PTX backend fixed. - beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions. - beehive-lab#514: Installer script fixed. - beehive-lab#540: Fix issue with clean-up execution IDs function. - beehive-lab#541: Fix Data Accessors for the prebuilt API. - beehive-lab#543: Fix checkstyle condition and FP16 error message improved. minor change

Issue #506 has been fixed.

aa244f9

Not used nodes, not related to any API or code, has been removed. GraalVM JIT has been added as provided dependency to improve IDE support.

jjfumero requested review from jjfumero and mikepapadim July 28, 2024 07:59

jjfumero self-assigned this Jul 28, 2024

jjfumero added fix Provides a fix OpenCL labels Jul 28, 2024

Fixed issue that caused printing of zero values in printf instead o…

aa5271d

…f correct values.

jjfumero requested a review from stratika July 29, 2024 07:52

jjfumero reviewed Jul 29, 2024

View reviewed changes

jjfumero approved these changes Jul 29, 2024

View reviewed changes

mikepapadim approved these changes Jul 29, 2024

View reviewed changes

stratika reviewed Jul 29, 2024

View reviewed changes

Additional tests were added for Debug.printf

b0683c7

jjfumero approved these changes Jul 30, 2024

View reviewed changes

stratika approved these changes Jul 30, 2024

View reviewed changes

jjfumero merged commit f1e670d into beehive-lab:develop Jul 30, 2024
2 checks passed

jjfumero mentioned this pull request Aug 30, 2024

[release] TornadoVM 1.0.7 #546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #506 has been fixed. #513

Issue #506 has been fixed. #513

andrii0lomakin commented Jul 27, 2024 •

edited by jjfumero

Loading

jjfumero commented Jul 29, 2024

jjfumero Jul 29, 2024

jjfumero left a comment

jjfumero commented Jul 29, 2024

andrii0lomakin commented Jul 29, 2024

mikepapadim left a comment

stratika Jul 29, 2024

jjfumero Jul 29, 2024

stratika left a comment

stratika Jul 29, 2024

stratika commented Jul 29, 2024

andrii0lomakin commented Jul 30, 2024

jjfumero left a comment

stratika left a comment

jjfumero commented Jul 30, 2024

		public void testPrintIntArray() throws TornadoExecutionPlanException {
		assertNotBackend(TornadoVMBackendType.SPIRV);

Issue #506 has been fixed. #513

Issue #506 has been fixed. #513

Conversation

andrii0lomakin commented Jul 27, 2024 • edited by jjfumero Loading

OS tested

Did you check on FPGAs?

How to test the new patch?

jjfumero commented Jul 29, 2024

jjfumero Jul 29, 2024

Choose a reason for hiding this comment

jjfumero left a comment

Choose a reason for hiding this comment

jjfumero commented Jul 29, 2024

andrii0lomakin commented Jul 29, 2024

mikepapadim left a comment

Choose a reason for hiding this comment

stratika Jul 29, 2024

Choose a reason for hiding this comment

jjfumero Jul 29, 2024

Choose a reason for hiding this comment

stratika left a comment

Choose a reason for hiding this comment

stratika Jul 29, 2024

Choose a reason for hiding this comment

stratika commented Jul 29, 2024

andrii0lomakin commented Jul 30, 2024

jjfumero left a comment

Choose a reason for hiding this comment

stratika left a comment

Choose a reason for hiding this comment

jjfumero commented Jul 30, 2024

andrii0lomakin commented Jul 27, 2024 •

edited by jjfumero

Loading