Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 4946 #4954

Merged
merged 5 commits into from
May 23, 2022
Merged

fix issue 4946 #4954

merged 5 commits into from
May 23, 2022

Conversation

runner361
Copy link
Contributor

fix issue "#4946"

test for fix of issue 4946
@flycash
Copy link
Collaborator

flycash commented May 22, 2022

Please help to add this merge request to CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #4954 (18a9813) into develop (daf779f) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #4954      +/-   ##
===========================================
- Coverage    54.70%   54.64%   -0.06%     
===========================================
  Files          244      244              
  Lines        21825    21825              
===========================================
- Hits         11940    11927      -13     
- Misses        8932     8942      +10     
- Partials       953      956       +3     
Impacted Files Coverage Δ
server/web/tree.go 83.75% <100.00%> (ø)
client/httplib/filter/prometheus/filter.go 62.50% <0.00%> (-37.50%) ⬇️
server/web/session/sess_mem.go 31.68% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf779f...18a9813. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@flycash
Copy link
Collaborator

flycash commented May 23, 2022

please rebase your merge request to 1 commit

@flycash flycash merged commit 64cf44d into beego:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants