fix(orm): txOrm miss debug log

[a631807682]

Close #4674

[flycash]

I think this is not a good solution. We have dbQueryLog, and we will use it when DEBUG is true:

So as my understanding, when users use DEBUG=true, it should prints debug log.
And could you help to confirm that?

[a631807682]

https://github.com/beego/beego/blob/develop/client/orm/orm.go#L536
@flycash Seems DoTx use new TxDB , so it lost query log when debug.

[flycash]

how about update this?

	_txOrm := &txOrm{
		ormBase: ormBase{
			alias: o.alias,
			db:    newDbQueryLog(o.alias, tx),
		},
	}

[flycash]

_txOrm := &txOrm{
ormBase: ormBase{
alias: o.alias,
db: newDbQueryLog(o.alias, &TxDB{tx:tx}),
},
}

[a631807682]

_txOrm := &txOrm{
ormBase: ormBase{
alias: o.alias,
db: newDbQueryLog(o.alias, &TxDB{tx:tx}),
},
}

we can't do this, dbQuerier print debug log although Debug flag is false, i create a test for it.

9b14501#diff-c3b3b1de3f657359cafc028e17ae972b7e2e1a5965fe23e02d89d2cac8e021c7R2916

[flycash]

nice, please resolve the conflicts and rebase your PR to one commit id

[codecov-commenter]

Codecov Report

Merging #4756 (b1fbaa7) into develop (556e743) will increase coverage by 0.16%.
The diff coverage is 93.93%.

@@             Coverage Diff             @@
##           develop    #4756      +/-   ##
===========================================
+ Coverage    54.49%   54.66%   +0.16%     
===========================================
  Files          243      243              
  Lines        21723    21734      +11     
===========================================
+ Hits         11839    11881      +42     
+ Misses        8935     8903      -32     
- Partials       949      950       +1     

Impacted Files	Coverage Δ
client/orm/orm.go	79.80% <93.54%> (+6.71%)	⬆️
client/orm/filter_orm_decorator.go	86.94% <100.00%> (ø)
core/logs/file.go	67.27% <0.00%> (-3.64%)	⬇️
client/orm/db_alias.go	65.23% <0.00%> (-0.72%)	⬇️
client/orm/db.go	81.81% <0.00%> (+0.07%)	⬆️
task/task.go	68.81% <0.00%> (+0.80%)	⬆️
client/orm/orm_log.go	86.84% <0.00%> (+16.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556e743...b1fbaa7. Read the comment docs.

[flycash]

Please fix the golint issues(you can find them in Files Changed) and DeepSource issues (click detail and you can find it`.

Most of them were introduced by original developer, but I think you can help to fix them

[a631807682]

I will fix it later

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[a631807682]

getMiInd is split into getMi and getPtrMiInd func by DeepSource issues, i'm not sure if it is the best way. I will rebase all commit after review.

[flycash]

getMiInd is split into getMi and getPtrMiInd func by DeepSource issues, i'm not sure if it is the best way. I will rebase all commit after review.

It looks good. Thank you very much.