Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix code #4668

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Chore: fix code #4668

merged 5 commits into from
Jun 23, 2021

Conversation

Loyalsoldier
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #4668 (56b5044) into develop (57b303e) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4668   +/-   ##
========================================
  Coverage    54.84%   54.85%           
========================================
  Files          242      242           
  Lines        17751    17748    -3     
========================================
  Hits          9736     9736           
+ Misses        7059     7058    -1     
+ Partials       956      954    -2     
Impacted Files Coverage Δ
adapter/config/fake.go 0.00% <0.00%> (ø)
client/orm/filter/bean/default_value_filter.go 86.66% <ø> (-0.84%) ⬇️
server/web/session/session_config.go 100.00% <100.00%> (ø)
task/task.go 66.66% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b303e...56b5044. Read the comment docs.

@Loyalsoldier
Copy link
Contributor Author

I'm afraid the golangci-lint should not be fixed for backward compatibility.

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flycash flycash merged commit 2207201 into beego:develop Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants