improve code quality #4639
Merged
improve code quality #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4639 +/- ##
===========================================
+ Coverage 54.79% 54.80% +0.01%
===========================================
Files 243 243
Lines 17770 17770
===========================================
+ Hits 9737 9739 +2
+ Misses 7080 7076 -4
- Partials 953 955 +2
Continue to review full report at Codecov.
|
* replace min limit value with const values * remove duplicated testcase and add testcase * put together switch case statement * fill empty block of code
|
Kudos, SonarCloud Quality Gate passed!
|
flycash
approved these changes
May 31, 2021
|
@flycash Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello~.
Description
This PR fixes a few sonar problems.
reference issue #4434
Summary of changes