-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature issue #4402 finish router get example #4416
Feature issue #4402 finish router get example #4416
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4416 +/- ##
===========================================
+ Coverage 52.43% 52.66% +0.23%
===========================================
Files 225 225
Lines 17237 17344 +107
===========================================
+ Hits 9038 9135 +97
- Misses 7272 7278 +6
- Partials 927 931 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@changsongl 我在原来的issue之下comment了一下,你可以看一下。
这个PR其实很不错,不过还可以弄得更好,虽然风险会更大。你可以考虑给我发封邮件,留个微信号,我们可以线下沟通一番。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked @flycash
…/route-method-expressions
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
什么时间 release? |
This is not finished yet. I just write a quick demo for how to implement this feature for issue #4402. I may have some details to think about, but I just wanna make sure the implementation is ok. I post demo below.
http://127.0.0.1:8090/ping
hello world
@flycash @jianzhiyao