Incorrect glrnvim version in Cargo.lock makes build to fail when building with nix

[ddrcode]

I've created a nix script to build glrnvim as a nix package, but the build fails due to mismatch in Cargo.lock. I use v1.1.1 release, but the Cargo.lock there refers to v1.1.0. According to nix documentation (here: https://nixos.org/manual/nixpkgs/stable/), "The fetcher will verify that the Cargo.lock file is in sync with the src attribute, and fail the build if not. "

I know this is rather a hermetic problem, specific to nix, but please remember to make sure in the future releases that the Cargo.lock will be in sync with src. As a quick solution I've forked the project and corrected the version in my fork.

If you're interested - here is my nix build script:

{ rustPlatform, fetchFromGitHub }:

rustPlatform.buildRustPackage rec {
  name = "glrnvim";
  version = "v1.1.1";

  src = fetchFromGitHub {
    owner = "beeender";
    repo = "glrnvim";
    rev = "${version}";
    sha256 = "1nxxyj4nlvp0rm1vzpn1s6if77sb2k443a2g5x498qm8m3av4714";
  };

  cargoSha256 = "1b50kvl144njngnsr8k6kvnhsns97bcasss0b4v1lrkj01cpzwan";
}

If you'd be interested to integrate your project with nix package system or nix os, I'm happy to help.

And on a side note: great work and great idea - I really enjoy using glrnvim!

[beeender]

Thanks for reporting this!

If you'd be interested to integrate your project with nix package system or nix os, I'm happy to help.

Yes, please! I am not sure how does the nix packaging works. Does it need the build script only? In that case, maybe we can create a pkg directory and put it there? Also the arch's PKGBUILD can be moved there as well.

[beeender]

The Cargo.lock has been updated and the v1.1.1 tag has been moved to the latest commit (hope nobody noticed :P )
I guess the nix build can pass with v1.1.1 now.

Uh.. you have a SHA1 in the nix build script, that might need to be updated as well.

[ddrcode]

Thank yo so much for fixing the Cargo.lock in v1.1.1 (hope nobody noticed it besides us :) ). I can confirm everything works perfectly now and compiles. Of course I had to update the SHAs, so the script looks as follow now:

{ rustPlatform, fetchFromGitHub }:

rustPlatform.buildRustPackage rec {
  name = "glrnvim";
  version = "v1.1.1";

  src = fetchFromGitHub {
    owner = "beeender";
    repo = "glrnvim";
    rev = "${version}";
    sha256 = "1ibwk85y5pa312q8p20gfsybx0q3hn3brhjws9vn7y74clv2s9lb";
  };

  cargoSha256 = "1nahnsnl51yy6hy6jw1bsbriw7irgbq8j9h8nlrgw1c0s6wz84hm";
}

In regards making glrnvim available as nix package, we would need to create a PR for nixpackages with a script very similar to the one pasted above - I'm happy to do it for you. Now, after fixing the Cargo.lock, you don't have to do anything on your end.

[beeender]

Great! thanks!

[beeender]

@all-contributors please add @ddrcode for platform

[allcontributors]

@beeender

I've put up a pull request to add @ddrcode! 🎉

[ddrcode]

Wow, thank you. You can count on me in terms of nix integration