-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Feature/create alpine based dockerfile #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/create alpine based dockerfile #118
Conversation
LGTMY 👍🏻 cc @brandonskerritt |
Should we replace the default Docker image of RustScan with this one? :) |
Might want to run as a normal user rather than root to avoid surprises |
Dokcerbuild file fails locally, not quite sure how the rust base imagine works which is why I built used a os slim to build up. Future goals are to do the exact same with Alpine which in turn will reduce the image size (it's 298mb compress, 700~ uncompressed at the time being) The .deb wsa quite larger and required more interaction with in the first place Pathing / env issues? @Hydragyrum |
You'll probably want to configure Travis to push an official image to dockerhub |
The current debian file can be greatly reduced I agree, this was just a "bandaid" until I got the chance (and wanted to use RustScan ASAP without the loopholes of install rust & cargo etc) |
Ah you have to checkout the repo to build it, @CMNatic |
Added a non-privileged user to run the scan as per docker best-practices |
Sorry for only just getting to this. IRL things and whatnot.... Build works a-okay for me 👍🏻 nice touch on the non-root user @Hydragyrum Going to confirm with the other reviewers that they're happy for an intermediary cc @brandonskerritt Does the above sound good to you? With this, we can update the readme and allow users to either build from the above The long term idea is to publish an alpine-based docker image that compiles all from source |
@CMNatic the final image uses just alpine, the rust image is used for only for building. Note the 2 FROM commands in the dockerfile. |
As long as you're happy thats cool, do you want to add to the README in this PR and then submit an approval & merge? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission @Hydragyrum! Sorry it took a lil' while. We just wanted to get the scope of how we're going to CI this in the future (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after CI checks!
Here's a simple multi-stage docker file with the bare minimum.
It probably needs a bit of tweaking and testing, though it seems to find things locally :)