Improve Citrix CTX1 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SkeletalDemise
commented
Nov 17, 2022
SkeletalDemise
commented
- Citrix CTX1 decoder now handles subtraction overflows
- Removed uppercase check, now it can decode lowercase Citrix CTX1 strings
- Added 3 more tests
- Removed 2 redundant tests
- Added docs to every test
* Citrix CTX1 decoder now handles subtraction overflows * Removed uppercase check, now it can decode lowercase Citrix CTX1 strings * Added 3 more tests * Removed 2 redundant tests * Added docs to every test
bee-san
requested changes
Nov 17, 2022
* Renamed tests to be more clear * Errors now propagate up and get printed
SkeletalDemise
force-pushed
the
improve-citrix-cx1
branch
from
00af60c
to
fd62c91
Compare
bee-san
approved these changes
Nov 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.