Fix return values of AbstractPrinting.check_*_support

bedros · Nov 29, 2018 · 609b8f1 · 609b8f1
1 parent f81c5b7
commit 609b8f1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/qutebrowser/browser/browsertab.py b/qutebrowser/browser/browsertab.py
@@ -205,23 +205,23 @@ def __init__(self, tab: 'AbstractTab') -> None:
         self._widget = None
         self._tab = tab
 
-    def check_pdf_support(self) -> bool:
+    def check_pdf_support(self) -> None:
         """Check whether writing to PDFs is supported.
 
         If it's not supported (by the current Qt version), a WebTabError is
         raised.
         """
         raise NotImplementedError
 
-    def check_printer_support(self) -> bool:
+    def check_printer_support(self) -> None:
         """Check whether writing to a printer is supported.
 
         If it's not supported (by the current Qt version), a WebTabError is
         raised.
         """
         raise NotImplementedError
 
-    def check_preview_support(self) -> bool:
+    def check_preview_support(self) -> None:
         """Check whether showing a print preview is supported.
 
         If it's not supported (by the current Qt version), a WebTabError is

diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py
@@ -132,7 +132,7 @@ class WebEnginePrinting(browsertab.AbstractPrinting):
     """QtWebEngine implementations related to printing."""
 
     def check_pdf_support(self):
-        return True
+        pass
 
     def check_printer_support(self):
         if not hasattr(self._widget.page(), 'print'):