Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to cover enableWhen exists logic for integer, decimal and b… #63

Merged
merged 27 commits into from
Nov 27, 2023

Conversation

projkov
Copy link
Member

@projkov projkov commented Nov 10, 2023

…oolean

Ref: #60

@projkov
Copy link
Member Author

projkov commented Nov 21, 2023

enable-when-exist

@projkov
Copy link
Member Author

projkov commented Nov 21, 2023

@ir4y Still existing problems. We should decide what we need to do with them. We can discuss it tomorrow on the morning sync call.

  1. Looks like the test pipeline was broken a long time ago. This created a situation where tests from the web application are not actual now. I don't write about the sense of the tests, a mean a code base. Ex: it waiting for variables from hooks that are not provided now. Question: do we need to fix them? Currently all of them a skipped.
  2. I think the reason why the test pipeline was broken is the incorrect tsconfig file configuration. When we run the TSC command it builds the project and then we run the tests it will run tests from the lib folder. If we run tests before the TSC all works well. Question: do we need to find and fix the problem?

@projkov
Copy link
Member Author

projkov commented Nov 23, 2023

Add console warning

@projkov projkov merged commit 28a2e38 into master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant