This repository was archived by the owner on Mar 19, 2025. It is now read-only.
Make Docker restarts/rebuilds work when new gem versions are available.#42
Merged
sadleb merged 1 commit intobebraven:masterfrom Oct 21, 2019
Merged
Make Docker restarts/rebuilds work when new gem versions are available.#42sadleb merged 1 commit intobebraven:masterfrom
sadleb merged 1 commit intobebraven:masterfrom
Conversation
We weren't .dockerignore'ing Gemfile.lock, so when you last built the Docker image it built whatever Gemfile.lock (which is .gitignored) into the image. This may not match what `bundle install` installs and things fail. Just ignore this file in the image build for now. The proper solution is to check-in Gemfile.lock and have a process for how to update it, but since we're planning on getting rid of this app/server, I'm not investing time to fix this up properly. TESTING: - Did a fresh docker build (no cache) and it failed to start. Made this change and rebuilt. It started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't .dockerignore'ing Gemfile.lock, so when you last built
the Docker image it built whatever Gemfile.lock (which is .gitignored)
into the image. This may not match what
bundle installinstalls and thingsfail. Just ignore this file in the image build for now. The proper solution
is to check-in Gemfile.lock and have a process for how to update it, but since
we're planning on getting rid of this app/server, I'm not investing time to fix
this up properly.
TESTING:
and rebuilt. It started.
Foregoing code review b/c there is no code to review.