Closed
Conversation
Contributor
Author
|
Fixes #390 |
Collaborator
|
@Koeng101 is this ready to merge after conflicts are resolved? |
Contributor
Author
|
Good lord that last PR had a LOT of conflicts. Working on it, but basically yea its ready after those are ironed out |
Contributor
Author
|
Ready! |
|
|
||
|
|
||
|
|
||
| - GoldenGates with methylated sequences using lowercase letters (#391) |
Collaborator
There was a problem hiding this comment.
include note on function signature including what I think is a methylation flag in the clone function @Koeng101?
Contributor
Author
There was a problem hiding this comment.
what should I add to the following documentation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
I add the ability to use methylated sequences in GoldenGates
Why are you making these changes?
I need a way to simulate methylated GoldenGates
Are any changes breaking? (IMPORTANT)
Kinda? But IMO worth and not sure anyone else is using.
Pre-merge checklist
primers/primers_test.gofor what this might look like.CHANGELOG.mdin the[Unreleased]section.