forked from astral-sh/uv
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: adjust trampoline close_handles invalid to be safer (astral-sh#6792
) ## Summary Closes astral-sh#6699 On cases like the ones described in astral-sh#6699, `lpReserved2` somehow seems to report multiple file descriptors that were not tied to any valid handles. The previous implementation was faulting as it would try to dereference these invalid handles. This change moves to using `HANDLE` directly and check if its is_invalid instead before attempting to close them. ## Test Plan Manually tested and verified using `busybox-w32` like described in the issue. --------- Co-authored-by: konstin <konstin@mailbox.org>
- Loading branch information
Showing
7 changed files
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
crates/uv-trampoline/trampolines/uv-trampoline-aarch64-console.exe
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
crates/uv-trampoline/trampolines/uv-trampoline-aarch64-gui.exe
Binary file not shown.
Binary file modified
BIN
+512 Bytes
(100%)
crates/uv-trampoline/trampolines/uv-trampoline-i686-console.exe
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
crates/uv-trampoline/trampolines/uv-trampoline-i686-gui.exe
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
crates/uv-trampoline/trampolines/uv-trampoline-x86_64-console.exe
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
crates/uv-trampoline/trampolines/uv-trampoline-x86_64-gui.exe
Binary file not shown.