feat: Add fuzz target, fix several panics #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6
turns out there are at least 3 overflow issues (and likely many more). Adding a fuzzer is easy, fixing the things it finds is not. I'm also not sure what the preferred way of running the fuzzer is (e.g. on CI for each PR?)
I've fixed one overflow where I think the solution is obvious. But quickly things get less obvious.
fails on this line in
rc-zip/src/parse/eocd.rs
that needs to return some sort of format error, not sure which one yet (I suspect none of the existing errors fit).
fails with an overflow in
rc-zip/src/parse/central_directory_file_header.rs:151
, again the fix is not immediately obviousBy staring at these specific cases I'm sure I could come up with a fix, but I'm not sure what a good general process for fixing these issues looks like. It seems very likely that there will be more issues.