Merged
Conversation
Also use fixed width for the help text.
yagebu
force-pushed
the
typography
branch
2 times, most recently
from
43c7649 to
f81ff30
Compare
Member
|
At first I was not a fan of this change, but after using it for some days now, I really like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
14px. We want to display a lot of information, but12pxis just tiny.Overall, this should lead to a more consistent look. We should definitely ship fonts, if anyone is unhappy with the choices I've made, then please make a suggestion for what font to use. I've tried some other fonts in the layout, including Open Sans and Source Sans Pro, but Fira just looked best IMHO (and is a bit more distinctive than Open Sans for example)
PS: a great resource regarding typography: http://practicaltypography.com/