Skip to content

Remove any notion of variable-injector #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove any notion of variable-injector #4

merged 1 commit into from
Oct 17, 2023

Conversation

@remstos
Copy link
Contributor

@remstos remstos commented Oct 16, 2023 •
edited
Loading

Fixed #3

  • Static EnvironmentVariables.swift file, for now we keep the keys. We’ll remove the unnecessary ones progressively, and let the key in case we ever bring another environment variable setup sometimes.

@remstos remstos self-assigned this Oct 16, 2023
@remstos remstos requested a review from StefKors October 16, 2023 21:35
@remstos remstos mentioned this pull request Oct 16, 2023
Merged
@remstos remstos merged commit 5d7cead into main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefKors StefKors StefKors approved these changes

Assignees

@remstos remstos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make EnvironmentVariable a static file and remove variable_injector dependency

3 participants

@remstos @StefKors