Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unix Domain Sockets #37

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Support Unix Domain Sockets #37

merged 3 commits into from
Jun 5, 2020

Conversation

kamilkowalski
Copy link
Contributor

@kamilkowalski kamilkowalski commented May 30, 2020

Adds Unix domain socket support by extending the reporter configuration options with socket_path and changing how the connection is opened and data is sent based on its presence.

This is a draft - let me know if the initial idea looks good and I will continue with updating the docs. In the meantime, I'll do some testing with the DogStatsD agent.

Fixes #17.

@kamilkowalski
Copy link
Contributor Author

I just tested this with a Docker-based DogStatsD agent sharing a Unix domain socket via mounted volume - I was able to transmit metrics to Datadog successfully.

@kamilkowalski kamilkowalski marked this pull request as ready for review June 1, 2020 08:48
@kamilkowalski
Copy link
Contributor Author

Added some documentation - let me know if it's too much.

Copy link
Collaborator

@arkgil arkgil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Very happy to have tests for it. And just enough of documentation.

@arkgil arkgil changed the title Unix domain socket support Support Unix Domain Sockets Jun 5, 2020
@arkgil arkgil merged commit 1456e0e into beam-telemetry:master Jun 5, 2020
@kamilkowalski kamilkowalski deleted the unix-domain-socket branch June 5, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unix Domain Socket
2 participants