Support Datadog distributions metric in Datadog formatter #25
Conversation
|
|
hkrutzer
force-pushed
the
datadog-distributions-metric
branch
from
2bd6601 to
3c93490
Compare
| defp format_metric_value(%Metrics.Summary{}, value), | ||
| do: [format_number(value), "|ms"] | ||
| defp format_metric_value( | ||
| %Metrics.Summary{reporter_options: reporter_options}, |
There was a problem hiding this comment.
@hkrutzer how about we make Distribution reportable in Datadog format?
There was a problem hiding this comment.
The types of telemetry_metrics vs statsd metrics is a bit confusing, but the telemetry_metrics type requires a buckets option right? That doesn't make much sense here.. But the name would make a lot more sense.
There was a problem hiding this comment.
Yes, that doesn't make much sense. I'll bring that up in Telemetry.Metrics.
There was a problem hiding this comment.
| @@ -65,6 +65,8 @@ children = [ | |||
| Supervisor.start_link(children, ...) | |||
| ``` | |||
|
|
|||
| To use [Datadog's distributions metric type](https://docs.datadoghq.com/metrics/distributions/), add `formatter_options: [report_as: :distribution]` to your metric. | |||
There was a problem hiding this comment.
Would you mind moving this line to the section describing the Distribution metric?
There was a problem hiding this comment.
What section do you mean?
There was a problem hiding this comment.
Somewhere below here 👍
telemetry_metrics_statsd/lib/telemetry_metrics_statsd.ex
Lines 161 to 162 in e355ef7
| %Metrics.Summary{reporter_options: reporter_options}, | ||
| value | ||
| ) do | ||
| case Keyword.get(reporter_options, :report_as) do |
There was a problem hiding this comment.
I agree it would be nice to have a datadog mentioned somewhere in the option name or value. I'll try to come up with something.
There was a problem hiding this comment.
Let's just go with report_as: :datadog_distribution.
hkrutzer
force-pushed
the
datadog-distributions-metric
branch
from
3c93490 to
a8815b6
Compare
|
@hkrutzer could you rebase on master so that CI runs on latest supported versions? |
hkrutzer
force-pushed
the
datadog-distributions-metric
branch
from
a8815b6 to
02713ec
Compare
hkrutzer
force-pushed
the
datadog-distributions-metric
branch
from
02713ec to
8bcbd5d
Compare
Resolves #22