add billing_address_collection #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougw-bc
commented
Apr 20, 2022
dougw-bc
commented
- adds billing_address_collection as an optional checkout session create param
- adds billing_address_collection as an optional checkout session create param
|
Here is a link to the docs for this parameter - https://stripe.com/docs/api/checkout/sessions/object#checkout_session_object-billing_address_collection |
snewcomer
reviewed
Apr 20, 2022
| @@ -241,6 +246,7 @@ defmodule Stripe.Session do | |||
| optional(:payment_intent_data) => payment_intent_data, | |||
| optional(:payment_method_options) => payment_method_options(), | |||
| optional(:setup_intent_data) => setup_intent_data(), | |||
| optional(:billing_address_collection) => billing_address_collection(), | |||
There was a problem hiding this comment.
Can we simplify and inline String.t()? What do you think?
There was a problem hiding this comment.
Yea no problem, just following some of the other patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.