Allow errors to be returned by webhook handler #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webhook event handler is currently only allowed to have
:okas a response to an event. This means that if for whatever reason we need to reject the event, Stripe sees the following 500 HTTP status code error:{ "status": "Internal Server Error" }This provides 0 context and is semantically wrong.
Changes in this PR allow for
handle_event/1functions to return:erroror{:error, reason}for more context into an error that occurred. HTTP response will use400status code and contain the error message as a response body. Otherwise the behaviour remains unchanged and it will still raise for any other return values.resolves #697