Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCUMENTATION]: retries #565

Merged
merged 3 commits into from
Dec 3, 2019
Merged

[DOCUMENTATION]: retries #565

merged 3 commits into from
Dec 3, 2019

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer self-assigned this Nov 25, 2019
@coveralls
Copy link

coveralls commented Nov 25, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 88.467% when pulling 019671d on sn/doc-retries into d0743ab on master.

@dnsbty
Copy link
Contributor

dnsbty commented Dec 3, 2019

Typically I think having docs on private functions is discouraged. Seems like this would make more sense in the README or moduledoc for the Stripe module

@snewcomer
Copy link
Collaborator Author

Woops. Good catch 😓

@snewcomer snewcomer changed the title retries doc [DOCUMENTATION]: retries Dec 3, 2019
@snewcomer snewcomer merged commit 955cab5 into master Dec 3, 2019
@snewcomer snewcomer deleted the sn/doc-retries branch December 3, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snewcomer snewcomer

Labels
2.0 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stripe error idempotency_key_in_use
3 participants
@snewcomer @coveralls @dnsbty