Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tax_rate struct and api calls #491

Merged
merged 6 commits into from
May 28, 2019

Conversation

maartenvanvliet
Copy link
Member

See https://stripe.com/docs/api/tax_rates and https://stripe.com/docs/billing/migration/taxes#tax-percent-changes

TaxRates were added to Stripe, I've added them in this PR following the open api spec.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.714% when pulling ac93197 on maartenvanvliet:issues/add_tax_rate into 7c54802 on code-corps:master.

@coveralls
Copy link

coveralls commented May 8, 2019

Coverage Status

Coverage increased (+0.1%) to 86.441% when pulling 38ca50a on maartenvanvliet:issues/add_tax_rate into 43e3a39 on code-corps:master.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just a few thoughts. Great job!

test/stripe/subscriptions/tax_rate_test.exs Show resolved Hide resolved
lib/stripe/subscriptions/tax_rate.ex Show resolved Hide resolved
lib/stripe/subscriptions/tax_rate.ex Show resolved Hide resolved
lib/stripe/subscriptions/tax_rate.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@snewcomer snewcomer merged commit 0cb24e0 into beam-community:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants