Implement assert_stripe_requested/3
#487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenvanvliet
force-pushed
the
issues/add_request_assertions
branch
from
25d72eb
to
45d85d3
Compare
maartenvanvliet
force-pushed
the
issues/add_request_assertions
branch
from
45d85d3
to
07abeac
Compare
In the tests, a message is send with the request to the process. We can assert on this message and test whether the expected request was made.
maartenvanvliet
force-pushed
the
issues/add_request_assertions
branch
from
07abeac
to
178f555
Compare
snewcomer
reviewed
May 6, 2019
| assert expected_url == url | ||
|
|
||
| assert_stripe_request_body(expected_body, body) | ||
| assert_stripe_request_headers(expected_headers, headers) |
| expected_body = Keyword.get(extra, :body) | ||
| expected_headers = Keyword.get(extra, :headers) | ||
|
|
||
| assert_received({method, url, headers, body, _}) |
There was a problem hiding this comment.
Did you mean for these to be prefixed with expected_?
There was a problem hiding this comment.
No, they will pattern match to the received message. So url will contain the url the http client used. Right?
There was a problem hiding this comment.
oh i figured these had to be variables in this function's scope. Not seeing 'method' in this scope for example.
There was a problem hiding this comment.
They could've been pinned like assert_received({^expected_method, ^expected_url, headers, body, _}) as well.
There was a problem hiding this comment.
Ah it is a macro that is expecting to pattern match the received message into those variables, correct? Now I understand.
snewcomer
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assert_stripe_requested/3function was not yet implemented.To better test #480 (comment)
I implemented this function to test whether the request was actually called. This is done by sending a message to the current process and asserting whether it was received and has the right shape.
The a1147ee commit was the only one where I found a bug in the current code. All other fixes only concern the tests where the wrong thing was asserted because of a typo or another mistake.
In the case where two requests are made in a test, it is necessary to assert both requests. Otherwise the
assert_stripe_requested/3function might check the wrong request.In a few cases the body, query_params or the request headers were also passed allong to
assert_stripe_requested/3, these params are also asserted for being correct.