Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After starting to add some tests, I realized that the current URI implementation is very broken. Some of these tests are still failing.
I strongly suggest deprecating the usage of keyword lists as arguments, and only use maps.
_Don't do this_:
_But, do this:_
Then you can delegate all of the query string formatting directly to Elixir's
URI.encode_query
implementation, which will handle it properly.