Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deleted property to resources that can be deleted #419

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

snewcomer
Copy link
Collaborator

Under the assumption that when retrieving a deleted resource, that it will return the object with the deleted key. This is only mentioned in the custom docs however.

https://stripe.com/docs/api/customers/retrieve

closes #417

@snewcomer snewcomer self-assigned this Oct 19, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.505% when pulling ffc479e on snewcomer:sn/add-deleted-property into c15350a on code-corps:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.505% when pulling ffc479e on snewcomer:sn/add-deleted-property into c15350a on code-corps:master.

@snewcomer
Copy link
Collaborator Author

@praveenperera I'll wait a few days for your review before merging!

@praveenperera
Copy link

Looks good and I tested it works as expected:

{:ok,
 %Stripe.Customer{
   account_balance: nil,
   created: nil,
   currency: nil,
   default_source: nil,
   deleted: true,
   delinquent: nil,
   description: nil,
   discount: nil,
   email: nil,
   id: "cus_DleOHixcCyFTOW",
   invoice_prefix: nil,
   livemode: nil,
   metadata: nil,
   object: "customer",
   shipping: nil,
   sources: nil,
   subscriptions: nil,
   tax_info: nil,
   tax_info_verification: nil
 }}

Thanks! @snewcomer

@snewcomer snewcomer merged commit 9342077 into beam-community:master Oct 19, 2018
@snewcomer snewcomer deleted the sn/add-deleted-property branch October 19, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted Customer
3 participants