Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API base url configurable #230

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Conversation

anronin
Copy link

@anronin anronin commented Apr 5, 2017

Convenient when you need to test api calls, for example with the Bypass library

@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage increased (+0.08%) to 78.125% when pulling 80ef613 on anronin:master into 5a48cac on code-corps:master.

@joshsmith
Copy link
Contributor

joshsmith commented Apr 5, 2017

@anronin are you using Bypass right now to test?

@anronin
Copy link
Author

anronin commented Apr 5, 2017

yes, I'm testing it right now in my project and everything just fine

@joshsmith
Copy link
Contributor

Can you add some documentation for this and a test as well?

@joshsmith
Copy link
Contributor

Oh, I just realized this is a pull against master and not 2.0 (which is the branch we're actively working on).

@anronin
Copy link
Author

anronin commented Apr 6, 2017

yeah, in 2.0 this is already implemented as i understand, but i need this in stable version for now. So do i need to add test and docs?

@joshsmith
Copy link
Contributor

Docs would be helpful anyway, since we'll cut a release for hex.

@doomspork
Copy link
Member

This is awesome, thanks @anronin! Just ran into this today

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 78.125% when pulling 1482924 on anronin:master into 5a48cac on code-corps:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 78.125% when pulling 1482924 on anronin:master into 5a48cac on code-corps:master.

@anronin
Copy link
Author

anronin commented Apr 11, 2017

@joshsmith i've added docs, maybe anything else?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 78.125% when pulling 0a394cb on anronin:master into 5a48cac on code-corps:master.

@joshsmith
Copy link
Contributor

Hey @anronin sorry for delay here. Will check it out.

Copy link
Contributor

@joshsmith joshsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Can you squash your commits down to one and then we can merge?

@joshsmith
Copy link
Contributor

@anronin I've also invited you as a contributor now! Feel free to merge after that rebase/squash.

@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage increased (+0.08%) to 78.125% when pulling 748ddde on anronin:master into 5a48cac on code-corps:master.

@anronin
Copy link
Author

anronin commented Apr 13, 2017

@joshsmith nice! I'm not sure that I understand everything correctly, but it seems I do not have the right to merge. Right now I see this at the bottom:

This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests.

@anronin anronin merged commit 05ca35b into beam-community:master Apr 13, 2017
@anronin
Copy link
Author

anronin commented Apr 13, 2017

Sorry, haven't seen the invite in the mail inbox :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants