added 2 more fields to help with pagination as well as normalized key… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doomspork
reviewed
Sep 16, 2016
| @@ -31,8 +31,10 @@ defmodule Scrivener.Headers do | |||
| query: conn.query_string} | |||
| conn | |||
| |> put_resp_header("link", build_link_header(uri, page)) | |||
| |> put_resp_header("total", Integer.to_string(page.total_entries)) | |||
| |> put_resp_header("per-page", Integer.to_string(page.page_size)) | |||
| |> put_resp_header("total-pages", Integer.to_string(page.total_pages)) | |||
There was a problem hiding this comment.
What is the point of changing the header keys? It introduces a breaking change with previous versions and the gain is unclear.
|
@doomspork Yeah that's fair. The point was to just keep it consistent with the main scrivener mix, but I'll change it back to not break anything. |
…s to be the same as the main mix
|
Thank you @jbhatab, I'll cut a new version shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the main mix spits out 4 keys and I felt we should just be replicating this to keep things consistent.
Here's what scrivener gives.
page_number: 1
page_size: 25
total_entries: 4
total_pages: 1
Now scrivener headers will give the following headers:
page-number: 1
page-size: 25
total-entries: 4
total-pages: 1