Add option to build link from x-forwarded headers #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertored
force-pushed
the
forwarded-headers
branch
from
e0c2ef1 to
5257cd9
Compare
doomspork
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
My sincerest apologizes for the delay getting to your PR. This happened to be opened shortly after I seriously injured my back and was out of comission for awhile.
This change looks good so let's get it merged and documented 🎉
I hope you are well, thanks for getting involved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application using scrivener is being served by some proxy the generated link header can contain wrong values.
This PR adds an option to
Scrivener.Headers.paginatefor taking into account requestx-forwardedheaders for generating the link response header. The default behavior remains that of only usingconnfor building it.If you think is worth to add this feature I will also add it to documentation