Skip to content

fix private pool fallback#1752

Merged
luke-lombardi merged 1 commit into
mainfrom
ll/fix-private-fallback
Jul 7, 2026
Merged

fix private pool fallback#1752
luke-lombardi merged 1 commit into
mainfrom
ll/fix-private-fallback

Conversation

@luke-lombardi

@luke-lombardi luke-lombardi commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Fixes private pool fallback to managed pools by enforcing concurrency limits and honoring pool fallback settings. Adds early capacity checks and clear failure reasons to avoid silent failures.

  • Bug Fixes

    • Allow managed fallback only when Pool.Fallback is empty or internal (privatePoolAllowsManagedFallback).
    • Reserve managed quota before scheduling via managedConcurrencyLimit; fail with managed_fallback_concurrency_limit when blocked.
    • Check for an available/pending/provisionable managed path (hasManagedFallbackPath); fail with managed_fallback_no_capacity if none exists.
    • Treat any private pool as quota-exempt in privatePoolQuotaExempt; tests updated accordingly.
  • Refactors

    • Extracted managedConcurrencyLimit from getConcurrencyLimit for reuse in fallback quota checks.

Written for commit 75952ae. Summary will update on new commits.

Review in cubic

@luke-lombardi luke-lombardi merged commit 2255297 into main Jul 7, 2026
3 of 4 checks passed
@luke-lombardi luke-lombardi deleted the ll/fix-private-fallback branch July 7, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant