Skip to content

Conversation

@luke-lombardi
Copy link
Contributor

@luke-lombardi luke-lombardi commented Nov 20, 2025

Summary by cubic

Increase gRPC send and receive message size limits to 16 MB in the container runtime server to support larger payloads. Prevents errors and timeouts when handling big specs or log streams.

Written for commit 917cd42. Summary will update automatically on new commits.

@luke-lombardi luke-lombardi merged commit 555800c into main Nov 20, 2025
4 checks passed
@luke-lombardi luke-lombardi deleted the ll/bump-container-server-max-payload branch November 20, 2025 22:31
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="pkg/worker/container_server.go">

<violation number="1" location="pkg/worker/container_server.go:109">
Setting `grpc.MaxSendMsgSize` to 16 MB dramatically lowers the server’s default send limit (from ~2 GB) and will break RPCs that return large payloads such as file downloads.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

s.grpcServer = grpc.NewServer()
s.grpcServer = grpc.NewServer(
grpc.MaxRecvMsgSize(gRPCMaxRecvMsgSize),
grpc.MaxSendMsgSize(gRPCMaxSendMsgSize),
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting grpc.MaxSendMsgSize to 16 MB dramatically lowers the server’s default send limit (from ~2 GB) and will break RPCs that return large payloads such as file downloads.

Prompt for AI agents
Address the following comment on pkg/worker/container_server.go at line 109:

<comment>Setting `grpc.MaxSendMsgSize` to 16 MB dramatically lowers the server’s default send limit (from ~2 GB) and will break RPCs that return large payloads such as file downloads.</comment>

<file context>
@@ -99,7 +104,11 @@ func (s *ContainerRuntimeServer) Start() error {
-	s.grpcServer = grpc.NewServer()
+	s.grpcServer = grpc.NewServer(
+		grpc.MaxRecvMsgSize(gRPCMaxRecvMsgSize),
+		grpc.MaxSendMsgSize(gRPCMaxSendMsgSize),
+	)
+
</file context>
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants