-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a mechanism for generating entire tables #7
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 44 54 +10
=========================================
+ Hits 44 54 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needs a version bump :)
can we update the docs? E.g. the change in #8 should probably be replaced with this |
This adds functions `collect_tables`, which turns the output of `generate` into a `NamedTuple` of tables, and `generate_tables` which is just a convenience atop `collect_tables(generate(...))`.
The README was updated for the change to include an `rng` argument in method definitions but the package docs were not. This commit makes the example runnable. It also replaces the `OrderedDict` example with `collect_tables`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 45 54 +9
=========================================
+ Hits 45 54 +9 ☔ View full report in Codecov by Sentry. |
Version bumped, docs updated. Looks like #3 updated the README but not the docs, so the change made to the documentation is larger than it would otherwise be. |
Requesting re-review due to the docs change. |
This adds functions
collect_tables
, which turns the output ofgenerate
into aNamedTuple
of tables, andgenerate_tables
which is just a convenience atopcollect_tables(generate(...))
.Example using the setup in the package's README:
Closes #6
I've had this change locally for months and had just forgotten to push it. 🙃