Support passing VirtualNode objects to ReportError by Copilot · Pull Request #760 · bdunderscore/ndmf

Copilot · 2026-02-09T00:34:23Z

Plan: Support passing VirtualClips and other VirtualObjects to ReportError

Explore codebase and understand the issue
Add protected internal method to VirtualNode to retrieve original UnityEngine.Object
Update InlineError.AddContext to handle VirtualNode objects
Add unit tests for the new functionality
Improve test assertions based on code review feedback
Run security checks (CodeQL - No vulnerabilities found)
Fix test compilation error (VirtualClip.NewClip → VirtualClip.Create)
Add changelog entries to both CHANGELOG.md and CHANGELOG-PRERELEASE.md
Final validation

Implementation Summary

This PR successfully implements support for passing VirtualClips and other VirtualObjects (all derived from VirtualNode) to ReportError. The implementation resolves these virtual objects back to their original Unity objects when available for better error reporting.

Changes Made:

VirtualNode.cs: Added GetOriginalObject() protected internal method that returns the original Unity object (OriginalObject property value)
InlineError.cs:
- Added using statement for nadena.dev.ndmf.animator namespace
- Modified AddContext() method to check for VirtualNode objects BEFORE checking for Unity Objects (important since VirtualNode instances are not Unity Objects)
- When a VirtualNode is encountered:
  - If it has an original object, resolves it to that object and creates an ObjectReference
  - If it has no original object, uses the VirtualNode's ToString() representation
InlineErrorTests.cs:
- Added comprehensive unit tests for VirtualNode resolution
- Test for VirtualClip with original object (verifies reference is added)
- Test for VirtualClip without original object (verifies no reference is added, ToString is used)
CHANGELOG.md & CHANGELOG-PRERELEASE.md: Added entry for PR Support passing VirtualNode objects to ReportError #760

Security Summary:

✅ CodeQL scan completed with 0 alerts - No security vulnerabilities detected.

Original prompt

This section details on the original issue you should resolve

<issue_title>Support passing VirtualClips and other VirtualObjects to ReportError</issue_title>
<issue_description>ReportError should resolve these to their original objects; if an original object exists, it should be reported.

We should do this by adding a protected internal method to VirtualNode to retrieve the original UnityEngine.Object?.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Support passing VirtualClips and other VirtualObjects to ReportError #758

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Added GetOriginalObject() method to VirtualNode class - Modified InlineError.AddContext to resolve VirtualNode objects to their original Unity objects - Added unit tests for VirtualNode resolution in error reporting Co-authored-by: bdunderscore <64174065+bdunderscore@users.noreply.github.com>

Added assertions to verify that no references are added when a VirtualNode has no original object, and that the error is still created successfully using the VirtualNode's ToString representation. Co-authored-by: bdunderscore <64174065+bdunderscore@users.noreply.github.com>

bdunderscore · 2026-02-09T01:19:48Z

@copilot Address missing tests (check PR CI status). Also, add changelog entries (in both files); use the PR number for those entries.

- Fixed TestVirtualNodeWithoutOriginalObject to use VirtualClip.Create instead of NewClip - Added changelog entries to both CHANGELOG.md and CHANGELOG-PRERELEASE.md for PR #760 Co-authored-by: bdunderscore <64174065+bdunderscore@users.noreply.github.com>

Copilot · 2026-02-09T01:22:06Z

@copilot Address missing tests (check PR CI status). Also, add changelog entries (in both files); use the PR number for those entries.

Fixed in commit 2bf4d01:

Corrected test to use VirtualClip.Create() instead of non-existent NewClip() method
Added changelog entries to both CHANGELOG.md and CHANGELOG-PRERELEASE.md for PR Support passing VirtualNode objects to ReportError #760

bdunderscore · 2026-06-21T20:11:50Z

@copilot Rebase to the current main branch.

Copilot

Pull request overview

Adds support for passing virtual animator objects (derived from VirtualNode, e.g. VirtualClip) into error reporting so they resolve to their underlying UnityEngine.Object when available, improving ErrorReport.ReportError context and UI references.

Changes:

Added a VirtualNode API (GetOriginalObject) to expose the backing Unity object to internal systems.
Updated InlineError.AddContext to treat VirtualNode arguments as context objects and resolve them to ObjectReferences when possible.
Added unit tests and changelog entries documenting the new behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
UnitTests~/InlineErrorTests.cs	Adds coverage for `VirtualNode` arguments in `InlineError` substitutions/references.
Editor/ErrorReporting/InlineError.cs	Resolves `VirtualNode` arguments to original Unity objects (via `ObjectRegistry`) for error context.
Editor/API/AnimatorServices/VirtualObjects/VirtualNode.cs	Introduces `GetOriginalObject()` hook to retrieve the backing Unity object for a virtual node.
CHANGELOG.md	Documents the new `ReportError` behavior for virtual nodes in the main changelog.
CHANGELOG-PRERELEASE.md	Documents the new `ReportError` behavior for virtual nodes in the prerelease changelog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        [Test]
+        public void TestVirtualNodeWithoutOriginalObject()
+        {
+            // Create a mock VirtualNode without an original object
+            var virtualClip = VirtualClip.Create("NewClip");
+
+            // Create an error that includes the VirtualClip without an original object
+            var error = new InlineError(TEST_LOCALIZER, ErrorSeverity.Error, "Errors:test",
+                virtualClip, "arg1", "arg2");
+
+            // The error should still be created, and should use the VirtualNode's ToString representation
+            // Since there's no original object, no reference should be added
+            Assert.AreEqual(0, error.References.Length, "Expected no references to be added for VirtualNode without original object");
+
+            // The title should still be created successfully
+            var title = error.FormatTitle();
+            Assert.IsNotEmpty(title, "Expected a non-empty title");
+        }


+                // Create a VirtualClip that wraps the animation clip
+                var context = new CloneContext(GenericPlatformAnimatorBindings.Instance);
+                var virtualClip = VirtualClip.Clone(context, animClip);
+
+                // Create an error that includes the VirtualClip
+                var error = new InlineError(TEST_LOCALIZER, ErrorSeverity.Error, "Errors:test",
+                    virtualClip, "arg1", "arg2");
+
+                // Verify that the error has a reference to the original animation clip
+                Assert.IsNotEmpty(error.References, "Expected at least one reference to be added");
+
+                // The reference should point to the original animation clip
+                var reference = error.References[0];
+                Assert.IsNotNull(reference, "Expected a non-null reference");
+
+                // The title should contain the VirtualClip's name (which comes from the original clip)
+                var title = error.FormatTitle();
+                Assert.IsTrue(title.Contains("TestClip") || title.Contains("VirtualClip"), 
+                    $"Expected title to reference the clip, got: {title}");


…alclips-reporterror # Conflicts: # CHANGELOG-PRERELEASE.md # CHANGELOG.md

Copilot · 2026-06-21T20:19:31Z

@copilot Rebase to the current main branch.

Done in commit 095ab65 — merged the current main branch into the PR branch.

Initial plan

08f002e

Copilot AI assigned Copilot and bdunderscore Feb 9, 2026

Copilot started work on behalf of bdunderscore February 9, 2026 00:34 View session

Copilot AI and others added 2 commits February 9, 2026 00:36

Copilot AI changed the title ~~[WIP] Add support for passing VirtualClips to ReportError~~ Support passing VirtualNode objects to ReportError Feb 9, 2026

Copilot AI requested a review from bdunderscore February 9, 2026 00:44

Copilot finished work on behalf of bdunderscore February 9, 2026 00:44

Copilot started work on behalf of bdunderscore February 9, 2026 01:20 View session

Copilot finished work on behalf of bdunderscore February 9, 2026 01:22

bdunderscore marked this pull request as ready for review June 21, 2026 20:11

Copilot AI review requested due to automatic review settings June 21, 2026 20:11

Copilot started reviewing on behalf of bdunderscore June 21, 2026 20:11 View session

Copilot AI reviewed Jun 21, 2026

View reviewed changes

Copilot started work on behalf of bdunderscore June 21, 2026 20:16 View session

Merge remote-tracking branch 'origin/main' into copilot/support-virtu…

095ab65

…alclips-reporterror # Conflicts: # CHANGELOG-PRERELEASE.md # CHANGELOG.md

Copilot finished work on behalf of bdunderscore June 21, 2026 20:21

Navigation Menu

Support passing VirtualNode objects to ReportError - #760

Support passing VirtualNode objects to ReportError#760
bdunderscore with Copilot wants to merge 5 commits into
mainfrom
copilot/support-virtualclips-reporterror

Copilot AI commented Feb 9, 2026 •

edited

Loading

Uh oh!

bdunderscore commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

bdunderscore commented Jun 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI commented Jun 21, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan: Support passing VirtualClips and other VirtualObjects to ReportError

Implementation Summary

Changes Made:

Security Summary:

Comments on the Issue (you are @copilot in this section)

Uh oh!

bdunderscore commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

bdunderscore commented Jun 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI commented Jun 21, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 9, 2026 •

edited

Loading