First pass #1
Merged
First pass #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ran pre-commit on repo, merging with main branch |
mobiiin
pushed a commit
to mobiiin/vlfm
that referenced
this pull request
Feb 7, 2025
Okay, so I glanced at the existing code and copy-pasted some of the infrastructure over from the `bdai` repo, which includes: - pre-commit hooks: including `black` and `ruff` (not a lot of code yet, don't want to worry too much about it right now), and `mypy` (in disabled form) - `.gitignore`: with Naoki's existing stuff at the bottom - `pyproject.toml` - boiler plate stuff, upped Python version from 3.9 to 3.10 + one big issue (below). The biggest issue I see right now (from the perspective of "I'd like to move everything over to `bdai` eventually"): we can't use `conda`, and the current dependencies instructions in the Readme makes me think this is going to be a problem. I'd like to see a `pip install`able list in `pyproject.toml` or another solution - with everything else going on, might as well Dockerize (but if you do, you would still need the dependencies list). --------- Co-authored-by: Naoki Yokoyama <nyokoyama@theaiinstitute.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so I glanced at the existing code and copy-pasted some of the infrastructure over from the
bdairepo, which includes:blackandruff(not a lot of code yet, don't want to worry too much about it right now), andmypy(in disabled form).gitignore: with Naoki's existing stuff at the bottompyproject.toml- boiler plate stuff, upped Python version from 3.9 to 3.10 + one big issue (below).The biggest issue I see right now (from the perspective of "I'd like to move everything over to
bdaieventually"): we can't useconda, and the current dependencies instructions in the Readme makes me think this is going to be a problem. I'd like to see apip installable list inpyproject.tomlor another solution - with everything else going on, might as well Dockerize (but if you do, you would still need the dependencies list).