Skip to content

Convert to using the node test runner #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Convert to using the node test runner #181

merged 1 commit into from
May 26, 2025

Conversation

bcomnes
Copy link
Owner

@bcomnes bcomnes commented May 24, 2025

Converts the test suite to use the nodejs test runner.

@bcomnes
Copy link
Owner Author

bcomnes commented May 24, 2025

Used an agent to help with this, still need to line by line review it, but overall looks decent.

@bcomnes bcomnes force-pushed the node-test-runner branch from 7743e0a to a98da0e Compare May 24, 2025 18:33
@bcomnes
Copy link
Owner Author

bcomnes commented May 24, 2025

Reminder that the node test runner runs concurrently by default.

@bcomnes bcomnes requested a review from Copilot May 24, 2025 18:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request converts the test suite to use Node’s native test runner rather than the previous mocha‐based runner. Key changes include updating assertions and test declarations to use the new Node test runner API, updating package scripts and workflow configurations, and adjusting configuration files (such as ESLint and Knip) to accommodate these changes.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/*.js (all test files) Replaces require('assert').strict with node:assert/strict and converts "it" to "test" using the node:test module.
package.json Updates test and watch scripts to use node’s test runner instead of mocha.
eslint.config.js Adds "node" environment support alongside mocha.
.knip.jsonc Updates ignored dependencies by adding "spec".
.github/workflows/test.yml Changes the test command to "npm run test" in the CI workflow.

@bcomnes bcomnes force-pushed the node-test-runner branch from a98da0e to c3e4df8 Compare May 25, 2025 14:25
@bcomnes bcomnes force-pushed the node-test-runner branch from c3e4df8 to b2c22e1 Compare May 25, 2025 15:13
@bcomnes
Copy link
Owner Author

bcomnes commented May 26, 2025

Read through it. Looks good, tests are passing. Let's try it.

@bcomnes bcomnes merged commit af75f95 into master May 26, 2025
15 checks passed
@bcomnes bcomnes deleted the node-test-runner branch May 26, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants