-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coin count and value statistics #960
base: master
Are you sure you want to change the base?
Conversation
Importing the discussion from the issue:
We could copy the approach in this PR to Handshake for a similar issue: |
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 62.10% 62.12% +0.01%
==========================================
Files 156 158 +2
Lines 26077 26095 +18
==========================================
+ Hits 16195 16211 +16
- Misses 9882 9884 +2
Continue to review full report at Codecov.
|
Regarding migration, the existing db version and migration scripts could benefit from increased automation. There is an argument to not want the database to automatically upgrade, especially if it will take some time. So it may be useful to have a flag that can be sent at startup to perform automatic database upgrades, and would default to false. So instead of running the migration script manually, it could be to include a |
Update looks good, utACK for now @ 0a82ad9 |
Okay, I've started the migration script (untested) by adding it to the existing migration scripts. It should update the database version and fixes bip30 duplicate issues for existing databases. It was necessary to expose |
Also realized that, technically |
I've run a sync with the changes and it confirms it, and have the correct |
I've added corresponding code for |
Closes #959