-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean option http
to SPVNode
#927
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
=========================================
- Coverage 62.01% 62% -0.01%
=========================================
Files 156 156
Lines 26099 26100 +1
=========================================
- Hits 16184 16183 -1
- Misses 9915 9917 +2
Continue to review full report at Codecov.
|
Most http based tests run against the full node, not the spv node. I agree that not enabling the http servers could be useful, maybe an option |
I think the option should be also the same for |
@martindale concept ACK! I made a similar commit here to illustrate some of the bcoin conventions we'd need from this PR:
However, this approach has a drawback which we discussed on IRC: socket events will not fire if the The socket events require authentication for subscription, and that would mean that the |
@martindale any interest in finishing up this PR? If not we may just take it over to formalize it and stage for merge. |
Sharing my quick patch to disable HTTP listeners (re: #568). Comments and feedback desired, as I'm not sure of the side effects or current conventions (esp. re:
this.options
/this.config
). Tests seem to pass (surprisingly).